Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The terminal IME composition view appears on top of text sometimes and keeps moving while typing #11334

Closed
rebornix opened this issue Aug 31, 2016 · 16 comments
Closed

The terminal IME composition view appears on top of text sometimes and keeps moving while typing #11334

rebornix opened this issue Aug 31, 2016 · 16 comments
Assignees
@Tyriar
Labels
bug Issue identified by VS Code Team member as probable bug *not-reproducible Issue cannot be reproduced by VS Code Team member as described terminal General terminal issues that don't fall under another label upstream Issue identified as 'upstream' component related (exists outside of VS Code)

Comments

@rebornix
Copy link
Member

  • VSCode Version: 1.5.0-Insiders
  • OS Version: OSX

Steps to Reproduce:

  1. Open Integrated Terminal
  2. Switch to OSX's default Chinese IME
  3. Type nihao and see the behavior.

imeinterminal

Found this issue while verifying #9822.
@Tyriar Tyriar added this to the August 2016 milestone Sep 1, 2016
@Tyriar
Copy link
Member

Tyriar commented Sep 1, 2016

A fix to this will probably be too high risk due to the module refactor in xterm.js. Deferring to September since it's just a bit glitchy but should still work.

@Tyriar Tyriar modified the milestones: September 2016, August 2016 Sep 1, 2016
@Tyriar Tyriar mentioned this issue Sep 1, 2016
Closed
@Tyriar Tyriar mentioned this issue Sep 17, 2016
Closed
@Tyriar
Copy link
Member

Tyriar commented Sep 17, 2016

Fixing this related upstream issue may fix this xtermjs/xterm.js#273

@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug upstream Issue identified as 'upstream' component related (exists outside of VS Code) terminal General terminal issues that don't fall under another label labels Sep 17, 2016
@Tyriar Tyriar modified the milestones: October 2016, September 2016 Sep 25, 2016
@Tyriar
Copy link
Member

Tyriar commented Oct 23, 2016

I believe this will be fixed by the fix in #13229, not yet confirmed though.

@Tyriar Tyriar closed this as completed in a7edf83 Oct 23, 2016
@Tyriar
Copy link
Member

Tyriar commented Oct 23, 2016

@rebornix this may be fixed, please verify. If not I'll need to learn how to use your IME 😛

@rebornix
Copy link
Member Author

@Tyriar since the xterm-helper-textarea is positioned as absolute and seems right now we only generate left for it, the top value is always 0.

@Tyriar Tyriar reopened this Oct 24, 2016
@Tyriar Tyriar mentioned this issue Oct 24, 2016
Closed
@Tyriar
Copy link
Member

Tyriar commented Oct 24, 2016

PR is out upstream

@Tyriar Tyriar closed this as completed in e0f3e51 Oct 24, 2016
@Tyriar Tyriar reopened this Oct 25, 2016
@Tyriar
Copy link
Member

Tyriar commented Oct 25, 2016

The commit broke the build and was reverted, waiting until code freeze is finished to add it back.

@Tyriar Tyriar closed this as completed in 7d2aca6 Oct 27, 2016
@jrieken
Copy link
Member

jrieken commented Oct 28, 2016

Assuming Chinese IME is Pinyin Simplified I cannot get this to work. These are my steps

  • OS X, select Pinyin Simplified keyboard
  • in editor type ni, select first suggestion
  • in terminal type ni, select first suggestion, 🐛 it prompts to show all completions instead of inserting the character

oct-28-2016 10-16-55

@jrieken jrieken reopened this Oct 28, 2016
@jrieken jrieken added the verification-found Issue verification failed label Oct 28, 2016
@bpasero
Copy link
Member

bpasero commented Oct 28, 2016

Since this is not labeled important, moving out to November.

@bpasero bpasero modified the milestones: November 2016, October 2016 Oct 28, 2016
@Tyriar
Copy link
Member

Tyriar commented Oct 28, 2016

@rebornix can you double check this?

@rebornix
Copy link
Member Author

I don't run into the issue @jrieken had, but when I typed first character, like n, the composition view is missing but after I typed i, the composition view is shown.

@Tyriar
Copy link
Member

Tyriar commented Oct 29, 2016

Are you pressing tab to trigger the completion @jrieken?

@jrieken
Copy link
Member

jrieken commented Oct 31, 2016

No. I press 1 to select the suggestion. The suggestion show up as I type

@Tyriar Tyriar modified the milestones: January 2017, November 2016 Dec 5, 2016
@Tyriar Tyriar mentioned this issue Jan 12, 2017
Closed
@Tyriar Tyriar modified the milestones: January 2017, February 2017 Jan 23, 2017
@Tyriar Tyriar modified the milestones: Backlog, February 2017 Feb 15, 2017
@Tyriar Tyriar removed the verification-found Issue verification failed label Feb 15, 2017
@Tyriar
Copy link
Member

Tyriar commented Apr 20, 2017

@rebornix can you still repro this on Mac?

@Tyriar Tyriar added the info-needed Issue requires more information from poster label Apr 20, 2017
@rebornix
Copy link
Member Author

I can still reproduce this problem.

@Tyriar Tyriar removed the info-needed Issue requires more information from poster label Apr 21, 2017
@Tyriar
Copy link
Member

Tyriar commented Dec 22, 2017

I can't see the original problem anymore but I do see the related xtermjs/xterm.js#273 still which is tracked over there.

@Tyriar Tyriar closed this as completed Dec 22, 2017
@Tyriar Tyriar added the *not-reproducible Issue cannot be reproduced by VS Code Team member as described label Dec 22, 2017
@Tyriar Tyriar removed this from the Backlog milestone Dec 22, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Feb 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
bug Issue identified by VS Code Team member as probable bug *not-reproducible Issue cannot be reproduced by VS Code Team member as described terminal General terminal issues that don't fall under another label upstream Issue identified as 'upstream' component related (exists outside of VS Code)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@rebornix @bpasero @jrieken @Tyriar