Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terminal breaks layout when status bar is hidden if the IME is triggered at the bottom of the viewport #13229

Closed
Tyriar opened this issue Oct 5, 2016 · 1 comment
Closed

Terminal breaks layout when status bar is hidden if the IME is triggered at the bottom of the viewport #13229

Tyriar opened this issue Oct 5, 2016 · 1 comment
Assignees
@Tyriar
Labels
bug Issue identified by VS Code Team member as probable bug terminal General terminal issues that don't fall under another label upstream Issue identified as 'upstream' component related (exists outside of VS Code) verified Verification succeeded
Milestone
October 2016

Comments

@Tyriar
Copy link
Member

Tyriar commented Oct 5, 2016

Upstream issue: xtermjs/xterm.js#299
@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug upstream Issue identified as 'upstream' component related (exists outside of VS Code) terminal General terminal issues that don't fall under another label labels Oct 5, 2016
@Tyriar Tyriar added this to the October 2016 milestone Oct 5, 2016
@Tyriar Tyriar self-assigned this Oct 5, 2016
Tyriar added a commit that referenced this issue Oct 22, 2016
@Tyriar
Fix terminal output hiding during IME composition
6085bd8 
This would only happen when the viewport was not filled

Part of #13229
@Tyriar
Copy link
Member Author

Tyriar commented Oct 22, 2016

PR for this is out for upstream, if it isn't merged in time I can always cherry pick to the release branch on my fork xtermjs/xterm.js#320

@Tyriar Tyriar mentioned this issue Oct 23, 2016
Closed
@Tyriar Tyriar closed this as completed in a7edf83 Oct 23, 2016
@Tyriar Tyriar added the verified Verification succeeded label Oct 27, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
bug Issue identified by VS Code Team member as probable bug terminal General terminal issues that don't fall under another label upstream Issue identified as 'upstream' component related (exists outside of VS Code) verified Verification succeeded
Projects
None yet
Milestone
October 2016
Development

No branches or pull requests
1 participant
@Tyriar