Editor selection is not unset while navigating from Problems view

[sandy081]

Testing #98821

• Have following issue notebook

[{"kind":2,"language":"github-issues","value":"repo:microsoft/vscode assigne:@me label:settings","editable":true},{"kind":2,"language":"github-issues","value":"rep:microsoft/vscode assignee:@me label=1234","editable":true}]

• Open the notebook
• Navigate the problems in problems views using arrows
• Selection is not unset when navigating across cells. For eg: See that in the screenshot selection is set in two cells

[jrieken]

This is likely an issue with selectElement

[rebornix]

Good catch and yet another case for composite editor. Image you have two editors side by side and each one of them has a problem

and navigating between the problems will not unset the selection of the previous editor. The problems panel will only set new selection in an editor, thus if you are navigating problems in a single editor, the selection is always updated.

However in our scenario, we have composite editors in one notebook and those composite editors don't share selections. And also since the problems panel doesn't unset selections of previous cells, the selections are left over. The same behavior applies to Find All References, Find & Replace, etc.

[jrieken]

I have pushed a change that makes the selection color almost transparent when a cell isn't selected anymore. I think that's better than unsetting the selection of an inactive editor. Let me know what you think.

[jrieken]

⬆️ fyi @misolori

[miguelsolorio]

I think this is fine for now, once we support cell background colors I'd imagine we'd move towards that to match the selection in the editor.

[jrieken]

Thanks. I'll leave it like that then