Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problems are getting multi-selected #99140

Closed
sandy081 opened this issue Jun 2, 2020 · 6 comments
Closed

Problems are getting multi-selected #99140

sandy081 opened this issue Jun 2, 2020 · 6 comments
Assignees
@jrieken
Labels
bug Issue identified by VS Code Team member as probable bug languages-diagnostics Source problems reporting notebook verified Verification succeeded
Milestone
May 2020

Comments

@sandy081
Copy link
Member

sandy081 commented Jun 2, 2020

Testing #98821

Kapture 2020-06-02 at 18 41 04

🐛 See how problems are getting selected (multi) in the problems view while creating new cells
@jrieken
Copy link
Member

jrieken commented Jun 2, 2020

@sandy081 How is the selection managed? That's really nothing I have touched but might be an issue with the way ids are computed and now used?

@jrieken jrieken added bug Issue identified by VS Code Team member as probable bug languages-diagnostics Source problems reporting notebook labels Jun 2, 2020
@jrieken jrieken added this to the May 2020 milestone Jun 2, 2020
@sandy081
Copy link
Member Author

sandy081 commented Jun 2, 2020

I suspect we are generating same id for markers across cells?

vscode/src/vs/workbench/contrib/markers/browser/markersModel.ts

Line 177 in 187dedb

const markerId = this.id(resourceMarkers!.id, key, index);

@jrieken
Copy link
Member

jrieken commented Jun 3, 2020

Yeah, looks like it...

jrieken added a commit that referenced this issue Jun 3, 2020
@jrieken
also feed marker resource into id computation, #99140
1434f62
@jrieken
Copy link
Member

jrieken commented Jun 3, 2020

Pushed 1434f62 which fixes this. @sandy081 please take a quick look as this affect id computation which looks complicated.

@jrieken jrieken closed this as completed Jun 3, 2020
@sandy081
Copy link
Member Author

sandy081 commented Jun 3, 2020

All it is trying to do is make id unique and feeding resource of raw marker makes it. With this change we do no need id of resourceMarkers to compute id of markers but there is no harm in just leaving it.

@jrieken
Copy link
Member

jrieken commented Jun 3, 2020

ok, I can revisit this during debt week

@sandy081 sandy081 added the verified Verification succeeded label Jun 4, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jul 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jrieken jrieken

Labels
bug Issue identified by VS Code Team member as probable bug languages-diagnostics Source problems reporting notebook verified Verification succeeded
Projects
None yet
Milestone
May 2020
Development

No branches or pull requests
2 participants
@jrieken @sandy081