Support view type for creating new untitled file. #100034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bpasero
requested changes
Jun 13, 2020
src/vs/workbench/contrib/files/browser/fileActions.contribution.ts
Outdated
Show resolved
Hide resolved
src/vs/workbench/contrib/files/browser/fileActions.contribution.ts
Outdated
Show resolved
Hide resolved
| registry.registerWorkbenchAction(SyncActionDescriptor.from(CompareWithClipboardAction, { primary: KeyChord(KeyMod.CtrlCmd | KeyCode.KEY_K, KeyCode.KEY_C) }), 'File: Compare Active File with Clipboard', category.value); | ||
| registry.registerWorkbenchAction(SyncActionDescriptor.from(ToggleAutoSaveAction), 'File: Toggle Auto Save', category.value); | ||
| registry.registerWorkbenchAction(SyncActionDescriptor.from(ShowOpenedFileInNewWindow, { primary: KeyChord(KeyMod.CtrlCmd | KeyCode.KEY_K, KeyCode.KEY_O) }), 'File: Open Active File in New Window', category.value); | ||
|
|
||
| MenuRegistry.addCommand({ |
There was a problem hiding this comment.
This is a bit confusing to me, shouldn't this move to the // Commands section and be CommandsRegistry.registerCommand?
There was a problem hiding this comment.
On the other hand, isn't this command already registered via KeybindingsRegistry.registerCommandAndKeybindingRule
…n.ts Co-authored-by: Benjamin Pasero <benjpas@microsoft.com>
rebornix
commented
Jun 15, 2020
| @@ -61,6 +60,11 @@ if (isMacintosh) { | |||
| // Commands | |||
| CommandsRegistry.registerCommand('_files.windowOpen', openWindowCommand); | |||
| CommandsRegistry.registerCommand('_files.newWindow', newWindowCommand); | |||
| MenuRegistry.addCommand({ | |||
There was a problem hiding this comment.
I registered this command to MenuRegistry as it's part of registerWorkbenchAction, which consists of
CommandsRegistry.registerCommandKeybindingsRegistry.registerKeybindingRuleMenuRegistry.addCommandMenuRegistry.appendMenuItem
I'm not 100% sure of the intention of holding a cache of commands in the MenuRegistry and MenuRegistry.getCommand is used in quite a few places.
bpasero
requested changes
Jun 15, 2020
bpasero
approved these changes
Jun 15, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR makes opening an untitled custom/notebook editor possible. It includes two sets of changes
GlobalNewUntitledFileActionto commandNEW_UNTITLED_FILE_COMMAND_IDregisterWorkbenchActionis replaced byMenuRegistry.addCommand,MenuRegistry.appendMenuItemandappendToCommandPalette. @bpasero can you confirm if it's all I need to do?viewTypefor the command. This one is straightforward and doesn't affect existingCtrl/Cmd+Nexperience.