Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes #100364 #100374

Merged
merged 3 commits into from
Jun 17, 2020
Merged

fixes #100364 #100374

merged 3 commits into from
Jun 17, 2020

Conversation

isidorn
Copy link
Contributor

@isidorn isidorn commented Jun 17, 2020

fixes #100364

This PR simply cleans up the previous sloppy fix done by me.
I verified this indeed fixes the issue

@isidorn isidorn added this to the May 2020 Recovery milestone Jun 17, 2020
@isidorn isidorn requested a review from weinand June 17, 2020 10:21
@isidorn isidorn self-assigned this Jun 17, 2020
weinand
weinand approved these changes Jun 17, 2020
View reviewed changes
Copy link
Contributor

@weinand weinand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix looks good to me.

@isidorn
Copy link
Contributor Author

isidorn commented Jun 17, 2020

Thanks for reviewing.

@isidorn isidorn merged commit 78ea448 into release/1.46 Jun 17, 2020
@isidorn isidorn deleted the isidorn/noDebug-cleanup branch June 17, 2020 12:52
@github-actions github-actions bot locked and limited conversation to collaborators Aug 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@weinand weinand weinand approved these changes

Assignees

@isidorn isidorn

Labels
None yet
Projects
None yet
Milestone
May 2020 Recovery
Development

Successfully merging this pull request may close these issues.
2 participants
@isidorn @weinand