ensure we are not leaking buffer details from iconv-lite-umd for #79275

[gyzerok]

As we discussed in the issue we do not want to leak any Buffer shim details. They are not leaking already, however we can also make it very explicit.

[bpasero]

Hm, not entirely sure this is needed, but it is also not causing any harm.

[bpasero]

Actually, what about the direct use of Buffer.from? This is a pre-req for #100539 I would argue.

[gyzerok]

@bpasero what do you mean by direct use of Buffer.from?

[bpasero]

@gyzerok referring to this:

vscode/src/vs/base/node/encoding.ts

Line 68 in 8cd3fe0

const decoded = decoder.write(Buffer.from(VSBuffer.concat(bufferedChunks).buffer));

vscode/src/vs/base/node/encoding.ts

Line 92 in 8cd3fe0

target.write(decoder.write(Buffer.from(chunk.buffer)));

vscode/src/vs/base/node/encoding.ts

Line 237 in 8cd3fe0

const guessed = jschardet.detect(Buffer.from(buffer.slice(0, AUTO_ENCODING_GUESS_MAX_BYTES).buffer)); // ensure to limit buffer for guessing due to https://github.com/aadsm/jschardet/issues/53

My understanding is that we need to change to Uint8Array before we can move this to common because Buffer is not available in web environments.

[gyzerok]

@bpasero ohh, that's a major oversight 😅 I will close this PR then and will fix it in another one. Thank you for pointing that out!