Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add proposed webview view API #104601

Merged
merged 12 commits into from
Aug 20, 2020
Merged

Add proposed webview view API #104601

merged 12 commits into from
Aug 20, 2020

Commits on Aug 18, 2020

  1. Add proposed webview view API 

    For microsoft#46585

This adds a new `WebviewView` proposed api to VS Code that lets webview be used inside views. Webview views can be contributed using a contribution point such as :

```json
    "views": {
      "explorer": [
        {
          "type": "webview",
          "id": "cats.cat",
          "name": "Cats",
          "visibility": "visible"
        }
      ]
    },
```
    @mjbvz
    mjbvz committed Aug 18, 2020
    Configuration menu
    Copy the full SHA
    f5e898f View commit details
    Browse the repository at this point in the history

  2. Use proper activation event

    @mjbvz
    mjbvz committed Aug 18, 2020
    Configuration menu
    Copy the full SHA
    02311f2 View commit details
    Browse the repository at this point in the history

  3. Transparent background

    @mjbvz
    mjbvz committed Aug 18, 2020
    Configuration menu
    Copy the full SHA
    abb8c62 View commit details
    Browse the repository at this point in the history

  4. Fix resize observer

    @mjbvz
    mjbvz committed Aug 18, 2020
    Configuration menu
    Copy the full SHA
    a0bc12b View commit details
    Browse the repository at this point in the history

  5. Adding documentation

    @mjbvz
    mjbvz committed Aug 18, 2020
    Configuration menu
    Copy the full SHA
    8f465e1 View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2020

  1. Move webview view to new directory under workbench

    @mjbvz
    mjbvz committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    95179f9 View commit details
    Browse the repository at this point in the history

  2. Remove resolver 

    By moving the webviews view into their own fodler, I was able to avoid the cycle the resolver was originally introduced for
    @mjbvz
    mjbvz committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    8de75cf View commit details
    Browse the repository at this point in the history

  3. Use enum in more places

    @mjbvz
    mjbvz committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    2a1fd61 View commit details
    Browse the repository at this point in the history

  4. Hook up title and visible properties for webview views

    @mjbvz
    mjbvz committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    f548364 View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2020

  1. Remove test view

    @mjbvz
    mjbvz committed Aug 20, 2020
    Configuration menu
    Copy the full SHA
    83c68bd View commit details
    Browse the repository at this point in the history

  2. Prefer Thenable

    @mjbvz
    mjbvz committed Aug 20, 2020
    Configuration menu
    Copy the full SHA
    0a9d8b8 View commit details
    Browse the repository at this point in the history

  3. Add unknown view type error to collector

    @mjbvz
    mjbvz committed Aug 20, 2020
    Configuration menu
    Copy the full SHA
    00e2d19 View commit details
    Browse the repository at this point in the history