notebooks: remove impure renderer API #105035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the initial notebook renderer API and keeps the 'pure' renderer API described in #102644 and hacked-in previously. Remaining work in this area, in no particular order: - Add messaging context to postMessage as requested by Don (API proposal TBA) - Cleanups around how state is managed internally in the backLayerWebView - Deprecate the renderer `viewType` in favor of calling it the `id` or `rendererId` Q: I kept around some of the "transform" functions since the mime type picking happens there, not sure if there's a better place for this to happen now, or whether these methods should simply be renamed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the initial notebook renderer API and keeps the 'pure'
renderer API described in #102644 and hacked-in previously.
Remaining work in this area, in no particular order:
viewTypein favor of calling it theidorrendererIdQ: I kept around some of the "transform" functions since the mime type
picking happens there, not sure if there's a better place for this
to happen now, or whether these methods should simply be renamed.