Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes TypeScript select version inserts full path to tsserver.js #105664

Merged
merged 1 commit into from
Aug 31, 2020

Conversation

jeanp413
Copy link
Contributor

To fix it, I just used the dirname of tsServerPath

This PR fixes #105202

@mjbvz mjbvz added this to the August 2020 milestone Aug 31, 2020
@mjbvz mjbvz merged commit 8b1aca7 into microsoft:master Aug 31, 2020
@mjbvz
Copy link
Collaborator

mjbvz commented Aug 31, 2020

Thanks!

@jeanp413 jeanp413 deleted the fix-105202 branch August 31, 2020 23:08
@github-actions github-actions bot locked and limited conversation to collaborators Oct 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Select TypeScript Version" inserts full path to tsserver.js which breaks the language service
2 participants