Switches the 'Fix all' quick fix provider to use resolveCodeAction #107853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rheh
reviewed
Nov 5, 2020
| @@ -51,6 +51,9 @@ class ApplyCodeActionCommand implements Command { | |||
| } | |||
| } | |||
|
|
|||
| type ApplyFixAllCodeAction_args = { | |||
There was a problem hiding this comment.
Types should be PascalCase e.g. ApplyFixAllCodeAction_args -> ApplyFixAllCodeActionArgs
There was a problem hiding this comment.
As the maintainer of this code, I'm going with this name here :)
| @@ -384,7 +403,7 @@ function isPreferredFix( | |||
| return true; | |||
| } | |||
|
|
|||
| if (otherAction.isFixAll) { | |||
| if (otherAction instanceof VsCodeFixAllCodeAction) { | |||
There was a problem hiding this comment.
This and the above reference are the only usage of the isFixAll property on the VsCodeCodeAction class. Removing these makes the property redundant. Thus, it can be removed. However, it is better to encapsulate this logic within the class rather than having to use instanceOf. So, why not use the isFixAll and set the value to false in the super call within the VsCodeFixAllCodeAction constructor? (4 parameter)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made while testing #106410