Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GettingStartedService/Registry and initial getting started UI #111175

Merged
merged 8 commits into from
Nov 25, 2020

Conversation

JacksonKearl
Copy link
Contributor

Ref #106715 / #106717.

UI is still work in progress. Enabled by flag workbench.experimental.gettingStarted: true.

CC @sandy081 / @bpasero for changes to contrib files. (workspaceActions, extensions, themes, quickInput)

Copy link
Member

@sandy081 sandy081 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving for changes in extensions actions file

@bpasero
Copy link
Member

bpasero commented Nov 24, 2020

@JacksonKearl instead of having to report the progress on tasks in each of the actions, why not listen to command execution in one central place via ICommandService.onDidExecuteCommand and then track progress through that? Maybe we can change the API that you register a task and the associated command IDs that will complete the task and the registry could listen and update progress accordingly?

@JacksonKearl
Copy link
Contributor Author

@bpasero good idea, I've reverted most of the changes to external modules in favor of listening to onDidExecuteCommand, except for theme picker where I still explicitly emit an event when the user has selected a theme as opposed to simply running the command.

@JacksonKearl JacksonKearl merged commit 0921f71 into master Nov 25, 2020
@JacksonKearl JacksonKearl deleted the jackson/getting-started-backend branch November 25, 2020 22:05
@github-actions github-actions bot locked and limited conversation to collaborators Jan 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants