only call buffer once and store it on xterm creation #112844
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tyriar
reviewed
Jan 4, 2021
There was a problem hiding this comment.
@meganrogge can we instead fix this upstream? I expect caching the buffer here should fix the issue https://github.com/xtermjs/xterm.js/blob/5cb048094e23da22ccfe46666b87d1ad427dce6d/src/browser/public/Terminal.ts#L59
Yes I wanted to wait for your review because wondered about that too. |
|
closing because have created a PR on xterm.js to resolve the upstream issue |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #111562