Don't show again notification management #114105
Conversation
| @@ -363,6 +370,8 @@ export interface INotificationService { | |||
| * @param filter the filter to use | |||
| */ | |||
| setFilter(filter: NotificationsFilter): void; | |||
|
|
|||
| getNotifications(): INotificationItem[]; | |||
There was a problem hiding this comment.
I plan to remove this from the notificationService and will instead use the registry we talked about to get the storage keys
| @@ -120,6 +131,25 @@ class KeybindingsEditorInputFactory implements IEditorInputFactory { | |||
| } | |||
| } | |||
|
|
|||
| class NotificationsEditorInputFactory implements IEditorInputFactory { | |||
|
|
|||
| canSerialize(editorInput: EditorInput): boolean { | |||
There was a problem hiding this comment.
I don't think I need this yet
| @@ -569,19 +569,17 @@ export class TerminalInstance extends Disposable implements ITerminalInstance { | |||
| if (this._storageService.getBoolean(SHOW_TERMINAL_CONFIG_PROMPT, StorageScope.GLOBAL, true) && | |||
| this.hasHadInput && | |||
| !TERMINAL_CREATION_COMMANDS.includes(resolveResult.commandId)) { | |||
| this._notificationService.prompt( | |||
There was a problem hiding this comment.
adopting neverShowAgain for my terminal notification
| @@ -24,6 +25,10 @@ export class NotificationService extends Disposable implements INotificationServ | |||
| super(); | |||
| } | |||
|
|
|||
| getNotifications(): INotificationItem[] { | |||
There was a problem hiding this comment.
planning to remove this and will use registry to directly get the keys instead from storage
| run: () => { | ||
| this.storageService.store(id, true, scope, StorageTarget.USER); | ||
|
|
||
| this.getNotifications().push(<INotificationItem>{ neverShowAgain: true, id: id, label: 'label', when: 'whenever' }); |
There was a problem hiding this comment.
as we discussed, this won't work because we can't get all the info we need from the notification here. will have to register it with an id/key, label, and when description of when the notification gets fired
|
|
||
| async openNotifications(): Promise<void> { | ||
| const options = { pinned: true, revealIfOpened: true }; |
There was a problem hiding this comment.
Here if I try to instantiate the editor directly (rather than do that via the input), it doesn't work
Click the notification icon (bell) and then the settings gear to see the template for the notification management.