Add a dialog box when opening unsaved files in a custom editor #114947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mjbvz Ideally, as discussed, we would like to make this work for notebooks. I'm trying to identify the best place to move the code but the open flows seem to diverge around this point https://github.com/microsoft/vscode/blob/master/src/vs/workbench/services/editor/common/editorOpenWith.ts#L111. I was wondering if you had any thoughts on to where the fix would live to cover both places |
MarcoZehe
pushed a commit
to MarcoZehe/vscode
that referenced
this pull request
Feb 3, 2021
MarcoZehe
pushed a commit
to MarcoZehe/vscode
that referenced
this pull request
Feb 3, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when triggering the
reopen withcommand on files with unsaved channels leads to the custom editor being opened, but the existing tab staying open. This PR prompts the user to save or discard their changes before the custom editor is opened.