Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove editorOpenWith #116856

Merged
merged 23 commits into from
Feb 22, 2021
Merged

Remove editorOpenWith #116856

merged 23 commits into from
Feb 22, 2021

Commits on Feb 17, 2021

  1. Move editorOpenWith to the editorService

    @lramos15
    lramos15 committed Feb 17, 2021
    Configuration menu
    Copy the full SHA
    f1024f8 View commit details
    Browse the repository at this point in the history

  2. Remove custom editor input handling

    @lramos15
    lramos15 committed Feb 17, 2021
    Configuration menu
    Copy the full SHA
    773cb0f View commit details
    Browse the repository at this point in the history

  3. Merged changes

    @lramos15
    lramos15 committed Feb 17, 2021
    Configuration menu
    Copy the full SHA
    6cae5f3 View commit details
    Browse the repository at this point in the history

  4. Fix open with API command

    @lramos15
    lramos15 committed Feb 17, 2021
    Configuration menu
    Copy the full SHA
    60889c5 View commit details
    Browse the repository at this point in the history

Commits on Feb 18, 2021

  1. Merge remote-tracking branch 'upstream/main' into editorServiceOpenWith

    @bpasero
    bpasero committed Feb 18, 2021
    Configuration menu
    Copy the full SHA
    eac3a48 View commit details
    Browse the repository at this point in the history

  2. adopt master properly

    @bpasero
    bpasero committed Feb 18, 2021
    Configuration menu
    Copy the full SHA
    6138c86 View commit details
    Browse the repository at this point in the history

  3. Remove dnagling comment

    @lramos15
    lramos15 committed Feb 18, 2021
    Configuration menu
    Copy the full SHA
    399b72e View commit details
    Browse the repository at this point in the history

  4. Address some feedback

    @lramos15
    lramos15 committed Feb 18, 2021
    Configuration menu
    Copy the full SHA
    bf01999 View commit details
    Browse the repository at this point in the history

  5. Cleanup region comment. 

    Co-authored-by: Benjamin Pasero <benjamin.pasero@gmail.com>
    @lramos15 @bpasero
    lramos15 and bpasero authored Feb 18, 2021
    Configuration menu
    Copy the full SHA
    5b0dc61 View commit details
    Browse the repository at this point in the history

  6. Cleanup region comment. 

    Co-authored-by: Benjamin Pasero <benjamin.pasero@gmail.com>
    @lramos15 @bpasero
    lramos15 and bpasero authored Feb 18, 2021
    Configuration menu
    Copy the full SHA
    1cdc476 View commit details
    Browse the repository at this point in the history

  7. Update override typings

    @lramos15
    lramos15 committed Feb 18, 2021
    Configuration menu
    Copy the full SHA
    3cc1560 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'main' into editorServiceOpenWith

    @lramos15
    lramos15 authored Feb 18, 2021
    Configuration menu
    Copy the full SHA
    b6aad40 View commit details
    Browse the repository at this point in the history

  9. Fix missing picker

    @lramos15
    lramos15 committed Feb 18, 2021
    Configuration menu
    Copy the full SHA
    88bd032 View commit details
    Browse the repository at this point in the history

  10. Fix bug with reopen with

    @lramos15
    lramos15 committed Feb 18, 2021
    Configuration menu
    Copy the full SHA
    e3cbe87 View commit details
    Browse the repository at this point in the history

  11. Remove duplicate import

    @lramos15
    lramos15 committed Feb 18, 2021
    Configuration menu
    Copy the full SHA
    bea6f08 View commit details
    Browse the repository at this point in the history

Commits on Feb 20, 2021

  1. Merge remote-tracking branch 'upstream/main' into editorServiceOpenWith

    @bpasero
    bpasero committed Feb 20, 2021
    Configuration menu
    Copy the full SHA
    60bb8ba View commit details
    Browse the repository at this point in the history

  2. First round of feedback via changes 

    - OverrideOptions => EditorOverride
- It is safe to destructure (...) undefined
- Ensure when destructuring, override is always winning
- Not a big fan of shared builtinProviderDisplayName import
    @bpasero
    bpasero committed Feb 20, 2021
    Configuration menu
    Copy the full SHA
    e8b820b View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2021

  1. editorservice - static DEFAULT_EDITOR_OVERRIDE_ID

    @bpasero
    bpasero committed Feb 21, 2021
    Configuration menu
    Copy the full SHA
    32360ff View commit details
    Browse the repository at this point in the history

  2. editors - introduce a editor associations registry 

    This moves the relevant code out of the editor service.
    @bpasero
    bpasero committed Feb 21, 2021
    Configuration menu
    Copy the full SHA
    293664b View commit details
    Browse the repository at this point in the history

  3. cleanup editor picking

    @bpasero
    bpasero committed Feb 21, 2021
    Configuration menu
    Copy the full SHA
    f7b7f94 View commit details
    Browse the repository at this point in the history

  4. cleanup editor delegate

    @bpasero
    bpasero committed Feb 21, 2021
    Configuration menu
    Copy the full SHA
    8da2cec View commit details
    Browse the repository at this point in the history

  5. final 💄

    @bpasero
    bpasero committed Feb 21, 2021
    Configuration menu
    Copy the full SHA
    8694848 View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2021

  1. Merge remote-tracking branch 'upstream/main' into editorServiceOpenWith

    @lramos15
    lramos15 committed Feb 22, 2021
    Configuration menu
    Copy the full SHA
    78c5aff View commit details
    Browse the repository at this point in the history