Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add command 'explorer.selectedFiles' #3553 #117820

Closed
wants to merge 1 commit into from
Closed

Add command 'explorer.selectedFiles' #3553 #117820

wants to merge 1 commit into from

Conversation

QoobIY
Copy link

@QoobIY QoobIY commented Feb 27, 2021

This improvement allows you to get the URI of the selected files in explorer

This PR fixes #3553

@moshfeu
Copy link
Contributor

moshfeu commented Feb 27, 2021

Is it common to have a command to get information? I meam, what will happen if it been called from the command palette?

@QoobIY
Copy link
Author

QoobIY commented Feb 27, 2021

Is it common to have a command to get information? I meam, what will happen if it been called from the command palette?

It will return the same thing that would come to registerCommand (https://code.visualstudio.com/api/references/vscode-api#commands.registerCommand) as the second argument if the context menu was called in explorer. (list of URIs of selected files in explorer)

@isidorn isidorn added this to the Backlog milestone Mar 1, 2021
@isidorn
Copy link
Contributor

isidorn commented Mar 1, 2021

Thanks for your PR, however this is not how we would tackle that feature request.
Ideally we would introduce real API. Having a command is a workaround which we currently do not want to have.
Thus for now assigning this PR to the backlog and we have no plans to merge it in.

@QoobIY
Copy link
Author

QoobIY commented Mar 1, 2021

Thanks for your PR, however this is not how we would tackle that feature request.
Ideally we would introduce real API. Having a command is a workaround which we currently do not want to have.
Thus for now assigning this PR to the backlog and we have no plans to merge it in.

I can add it to api, tell me only in which of the object

@isidorn
Copy link
Contributor

isidorn commented Mar 1, 2021

We do not want to add it to the API just yet. Once we decide to do that it has to go through our API discussion process.

@QoobIY
Copy link
Author

QoobIY commented Mar 1, 2021

But in fact, this is already there, if you select the same action but through explorer/context

@moshfeu
Copy link
Contributor

moshfeu commented Mar 1, 2021

@isidorn is there ETA?

@isidorn
Copy link
Contributor

isidorn commented Mar 1, 2021

No. Backlog means no plans to tackle this at the moment.

@isidorn
Copy link
Contributor

isidorn commented Aug 18, 2021

No plans to merge, thus closing.

@isidorn isidorn closed this Aug 18, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Oct 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get selected file/folder in the explorer view
3 participants