Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix strange behavior of files.exclude in workspace with nested folders #118777

Merged
merged 2 commits into from
Mar 12, 2021
Merged

Fix strange behavior of files.exclude in workspace with nested folders #118777

merged 2 commits into from
Mar 12, 2021

Conversation

jeanp413
Copy link
Contributor

This PR fixes #118557

@jeanp413 jeanp413 mentioned this pull request Mar 12, 2021
Closed
@isidorn
Copy link
Contributor

isidorn commented Mar 12, 2021

@jeanp413 in my personal opinion best PR you have done so far in my area. Great work, fixes the issue, simplifies the code and improves the style. Love it.
I see you have dropped the URI visibility cache map, I had that because I was worried if isVisible will be called too much (it will happen on each explorer refresh). However that should not happen that often, since we have improved how we react on file events thus minimizing the number of refreshes.

Thus merging in.

I will also adopt your findClosestRoot in the select method in the explorerService

@isidorn isidorn merged commit 3aca77c into microsoft:main Mar 12, 2021
@isidorn isidorn added this to the March 2021 milestone Mar 12, 2021
@isidorn isidorn added the file-explorer Explorer widget issues label Mar 12, 2021
@jeanp413 jeanp413 deleted the fix-118557 branch March 14, 2021 19:10
@github-actions github-actions bot locked and limited conversation to collaborators Apr 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@isidorn isidorn

Labels
file-explorer Explorer widget issues
Projects
None yet
Milestone
March 2021
Development

Successfully merging this pull request may close these issues.

Strange behavior of files.exclude in workspace with nested folders
2 participants
@jeanp413 @isidorn