Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating this PR just as a sketch. After some discussions with team mates from Zurich here are some thoughts:
Here's the things which I think we need to do in order to have this in the core:
tensorflow-js
model and not have anode
dependency. We need to do this so we can run in the browser. Without this, even for VS Code desktop we would have to run the classification in the shared process, since we are moving towards node free renderers, and putting additional work in the shared process is not good.ILanguageDetectionService
, I created a skeleton for this and I can look into this further to have it integrated on the vscode side @isidornn
characters) and what is theconfidence
we should useIf we get the above working in a good way then we need to:
JSON
,xml
and other not supported languagesJS
/TS
confusionIf all of this proves to be too much overhead we can look into some simpler heuristic to detect a language and not use machine learning.
@TylerLeonhardt let me know what you think, and feel free to add your name to some of the items you are interested in and also feel free to add items I might have forgot.
fixes #118455