Initial move to a Publish stage #122886
Merged
Initial move to a Publish stage #122886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joaomoreno
approved these changes
May 5, 2021
TylerLeonhardt
force-pushed
the
TylerLeonhardt/better-release-stage-2
branch
2 times, most recently
from
1a61b04
to
6b377d1
Compare
actually run ok run it for real actually work parameter syntax monaco logging env var is always string use variables use global params try idea to stop looping move variables wrap in quotes rename all the artifacts try downloading up timeout misc underscore add auth log everything we need to typo typo publish linux client archives too renamed all that needed to be renamed better error handling raname windows assets first attempt at letting new code handle releasing with macOS move to $env remove gate include updated createAsset.js onboard windows client include js add linux client add built js move over all publishing update distro use branch name? processed artifacts and fix win32 server platforms publish what artifacts were published use download and more more to powershell put it all in exec actually in directory fix path again create file to be uploaded move to all PowerShell rename to publish and clean up code update createAsset use distro 2 more commented out code and add displayNames address feedback
TylerLeonhardt
force-pushed
the
TylerLeonhardt/better-release-stage-2
branch
from
743488f
to
cb31884
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #117891
Things to do before merge:
Out of scope but issues that will be opened after this goes in