use title for terminal selection #123478
Merged
use title for terminal selection #123478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connor4312
approved these changes
May 11, 2021
Co-authored-by: Connor Peet <connor@peet.io>
|
I just tested with the nightly build of the vscode-js-debug extension. This works and does prevent creating additional terminals. |
|
This looks good to me. However I know @weinand is back from vacation next week so I suggest we wait for him before we merge this in. |
|
Any update on this? I'm happy to make changes if needed. |
|
@danielgary we are currently in Endgame week and we are only working on fixing issues. |
weinand
added
the
debug
weinand
approved these changes
Jun 7, 2021
|
@danielgary thanks for the PR |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #123189
This should guarantee that all launch configurations that use integrated terminal should always receive a terminal with their name. It should also help fix issues related to vscode opening multiple terminals for the same launch process.