Refine CellInfo type
#125351
Merged
Refine CellInfo type
#125351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For #125269 - Rename `CellInfo` - >`OutputItem` (only internally, we also need to update the published types) - Move `id` into `OutputItem` - Move `element` out of `OutputItem` - Rename `renderCell` to `renderOutputItem` - Rename `destoryCell` to `disposeOutputItem` (`dispose` is the term we generally use in our APIs)
jrieken
approved these changes
Jun 3, 2021
connor4312
approved these changes
Jun 3, 2021
|
Yes the asymmetry is not great. I don't think we can pass in the |
mjbvz
added a commit
to mjbvz/DefinitelyTyped
that referenced
this pull request
Jun 3, 2021
8 tasks
typescript-bot
pushed a commit
to DefinitelyTyped/DefinitelyTyped
that referenced
this pull request
Jun 3, 2021
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #125269
CellInfo- >OutputItem(only internally, we also need to update the published types)idintoOutputItemelementout ofOutputItemrenderCelltorenderOutputItemdestoryCelltodisposeOutputItem(disposeis the term we generally use in our APIs)