Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bulk install event for python extensions #128112

Merged
merged 2 commits into from
Jul 7, 2021
Merged

Conversation

sandy081
Copy link
Member

@sandy081 sandy081 commented Jul 7, 2021

This PR fixes #128088

This is temporary low risk, low impact fix for above issue. Introduced bulk install flag and event only for python extensions.
Extension runtime will ignore singular install events with bulk install flag and react to bulk install event.

Note: This is to fix only when installing python or pylance extension but not when installing the packs that includes these extensions.

This is the best safe changes we can do given that we are end of the milestone .
Going forward the proper fix will take care of all possibilities

@sandy081 sandy081 requested a review from alexdima July 7, 2021 10:23
@sandy081 sandy081 self-assigned this Jul 7, 2021
@sandy081 sandy081 added this to the June 2021 milestone Jul 7, 2021
@sandy081 sandy081 merged commit 2d23c42 into release/1.58 Jul 7, 2021
@sandy081 sandy081 deleted the sandy081/1.58/fix128088 branch July 7, 2021 11:18
@github-actions github-actions bot locked and limited conversation to collaborators Aug 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants