Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip acquiring workspace storage locks on the local nodejs extension host #128541

Merged
merged 1 commit into from
Jul 14, 2021
Merged

Skip acquiring workspace storage locks on the local nodejs extension host #128541

merged 1 commit into from
Jul 14, 2021
+13 −1

Conversation

alexdima
Copy link
Member

@alexdima alexdima commented Jul 13, 2021 •
edited
Loading

Fixes #128528

  • adds a new command line flag to the extension host called --skipWorkspaceStorageLock.
  • this is used to skip acquiring a lock for the workspace storage.
  • this is then exercised by the local process extension host spawning code.

@alexdima alexdima added the candidate Issue identified as probable candidate for fixing in the next release label Jul 13, 2021
@alexdima alexdima added this to the June 2021 Recovery 2 milestone Jul 13, 2021
@alexdima alexdima merged commit 5cfe44b into release/1.58 Jul 14, 2021
@alexdima alexdima deleted the alex/128528 branch July 14, 2021 08:56
@github-actions github-actions bot locked and limited conversation to collaborators Aug 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jrieken jrieken

Assignees
No one assigned
Labels
candidate Issue identified as probable candidate for fixing in the next release
Projects
None yet
Milestone
June 2021 Recovery 2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alexdima @jrieken