Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add type hierarchy provider #128667

Merged
merged 6 commits into from
Jul 15, 2021
Merged

Conversation

Eskibear
Copy link
Member

This PR is part of Type Hierarchy API.
corresponding LSP proposal in microsoft/language-server-protocol#1231
early investigation here: microsoft/vscode-languageserver-node#779

This PR includes:

  • type hierarchy provider and registry
  • related API in vscode.proposed.d.ts

src/vs/vscode.proposed.d.ts Outdated Show resolved Hide resolved
@Eskibear
Copy link
Member Author

@dbaeumer @jrieken
So far I only tested the proposed api with a sample extension, and the provider was successfully registered.
Please help to keep me on the right track. Thanks.

Signed-off-by: Yan Zhang <yanzh@microsoft.com>
Copy link
Member

@jrieken jrieken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nit, enforcing proposed API is the most important

src/vs/vscode.proposed.d.ts Outdated Show resolved Hide resolved
@jrieken
Copy link
Member

jrieken commented Jul 15, 2021

Thanks, this is looking pretty good already

Signed-off-by: Yan Zhang <yanzh@microsoft.com>
Signed-off-by: Yan Zhang <yanzh@microsoft.com>
Signed-off-by: Yan Zhang <yanzh@microsoft.com>
Signed-off-by: Yan Zhang <yanzh@microsoft.com>
Signed-off-by: Yan Zhang <yanzh@microsoft.com>
@Eskibear Eskibear marked this pull request as ready for review July 15, 2021 10:07
@jrieken jrieken merged commit 1ba9d7b into microsoft:main Jul 15, 2021
@jrieken
Copy link
Member

jrieken commented Jul 15, 2021

Thanks @Eskibear

@jrieken
Copy link
Member

jrieken commented Jul 15, 2021

fyi - I have pushed f50840e which adds an API command test.

test('TypeHierarchy, back and forth', async function () {

There was actually a bug in call hierarchy that also made it into the type hierarchy. This should be resolved now which is goodness. Using the call hierarchy in the references viewlet should now be possible

@Eskibear Eskibear deleted the type-hierarchy-provider branch July 16, 2021 00:44
@github-actions github-actions bot locked and limited conversation to collaborators Aug 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants