Move event listeners to renderTemplate in disassembly view #129734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@isidorn I moved all listeners in renderElement to renderTemplate. Now if the screen is very large or the zoom level is very small, there will be only one warning. This is kind of expected, as listeners are only created once for each line in the viewport, but still inevitably there will be one warning when there are too many lines in the viewport. I'm not sure if we can remove this warning? |
|
@xisui-MSFT this looks great, but is a bit of a larger change, so I am assigning this to August and I will merge in start of next week. As for still getting a warning for a large disassembly view, this is fine. Those warning are not 100% correct, and are there to point to potential problems. In this case it is fine. Thanks 👏 |
isidorn
approved these changes
Jul 29, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #129527
Move event listeners to renderTemplate in disassembly view, to avoid frequently creating and disposing event listeners.