Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

peek type hierarchy #130922

Merged
merged 1 commit into from
Aug 18, 2021
Merged

peek type hierarchy #130922

merged 1 commit into from
Aug 18, 2021

Conversation

Eskibear
Copy link
Member

Part of #15533 This PR adds UI for "Peek Type Hierarchy".

CSS file and common data structures (e.g. State, LayoutInfo) are copied from call hierarchy implementation. It would be better to extract them to a proper place.

Signed-off-by: Yan Zhang <yanzh@microsoft.com>
@Eskibear
Copy link
Member Author

I tested it with a mock extension, with type hierarchy provider implemented for plaintext files. Each word represents a type, inheriting all types from previous line.

peek-type-h.mp4

Copy link
Member

@jrieken jrieken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. This looks good despite being mostly identical to the call hierarchy peek. I will proceed with merging so that we have this in the product and then I will spend some cycles to reduce the duplication.

@jrieken jrieken added this to the August 2021 milestone Aug 18, 2021
@jrieken jrieken merged commit 45c8224 into microsoft:main Aug 18, 2021
@Eskibear
Copy link
Member Author

Thank you. I was just trying to get it working, and it definitely requires you vscode expert to refine the code.

And one thing to mention, I assigned the same alt-shift-h keybinding with call-h that I'm not sure about potential conflicts.

@jrieken
Copy link
Member

jrieken commented Aug 18, 2021

I assigned the same alt-shift-h keybinding with call-h that I'm not sure about potential conflicts.

Yeah, that I removed for now. We can try to find a better one but most are in use unfortunately.

@github-actions github-actions bot locked and limited conversation to collaborators Oct 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants