-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding most frequently used file associations #131048
Conversation
All code changes look good, great work 👏 Great that you added them sorted to the win file. @digitarald did you build VS Code, so we try this out end to end before merging? Just in case I triggered a build off this branch so hopefully we should have something soon to try out and make sure we did not break anything. Once we have a build and all looks good I suggest you merge this in. Thanks! fyi @bpasero as an optional reviewer (in case you feel like it) |
We were unlucky that there was an unrelated compilation error when triggering builds. Thus I merged |
@isidorn I added a fix recommended by @deepak1556. I couldn't figure out how to trigger the build in time though. |
@digitarald oh so you also had to change the javascript file. Okey. I triggered another build and then you can verify mac, and I will do Win on my VM. |
@isidorn thank you, also for teaching me how to fish! It tested on mac for most added file types 👍. If all looks good on Windows, feel free to merge. |
Looks good on Windows. I tried out the fyi @xandfis |
As an addition to #127075, this patch expands registered file types for VS Code based on widely and frequently used file extensions.