Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding most frequently used file associations #131048

Merged
merged 4 commits into from
Aug 20, 2021
Merged

Conversation

digitarald
Copy link
Contributor

As an addition to #127075, this patch expands registered file types for VS Code based on widely and frequently used file extensions.

@digitarald digitarald added the install-update VS Code installation and upgrade system issues label Aug 18, 2021
@digitarald digitarald requested a review from isidorn August 18, 2021 01:03
@digitarald digitarald self-assigned this Aug 18, 2021
@isidorn isidorn added this to the August 2021 milestone Aug 18, 2021
@isidorn
Copy link
Contributor

isidorn commented Aug 18, 2021

All code changes look good, great work 👏 Great that you added them sorted to the win file.

@digitarald did you build VS Code, so we try this out end to end before merging? Just in case I triggered a build off this branch so hopefully we should have something soon to try out and make sure we did not break anything. Once we have a build and all looks good I suggest you merge this in. Thanks!
https://monacotools.visualstudio.com/Monaco/_build/results?buildId=131485&view=results

fyi @bpasero as an optional reviewer (in case you feel like it)

@isidorn
Copy link
Contributor

isidorn commented Aug 18, 2021

We were unlucky that there was an unrelated compilation error when triggering builds. Thus I merged main on top and re-triggered build.
https://monacotools.visualstudio.com/Monaco/_build/results?buildId=131503&view=results

@digitarald
Copy link
Contributor Author

@isidorn I checked the darwin builds from the artifacts and could not see the added file types in the Info.plist. I'll be trying to build locally and at least validate on macOS.

@digitarald
Copy link
Contributor Author

@isidorn I added a fix recommended by @deepak1556. I couldn't figure out how to trigger the build in time though.

@isidorn
Copy link
Contributor

isidorn commented Aug 19, 2021

@digitarald oh so you also had to change the javascript file. Okey. I triggered another build and then you can verify mac, and I will do Win on my VM.
https://monacotools.visualstudio.com/Monaco/_build/results?buildId=131628&view=results

@digitarald
Copy link
Contributor Author

@isidorn thank you, also for teaching me how to fish! It tested on mac for most added file types 👍. If all looks good on Windows, feel free to merge.

@isidorn
Copy link
Contributor

isidorn commented Aug 20, 2021

Looks good on Windows. I tried out the .dart extension.
Merging so we get feedback start of next week since this should be in Insiders on Monday.

fyi @xandfis

@isidorn isidorn merged commit b3579dc into main Aug 20, 2021
@isidorn isidorn deleted the digitarald/more-filetypes branch August 20, 2021 09:28
@github-actions github-actions bot locked and limited conversation to collaborators Oct 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
install-update VS Code installation and upgrade system issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants