Git sync info

[joaomoreno]

Proposed alternative to #13313, fixes #8655

@chrmarti @bgashler1 This is what I meant.

The tooltip shows instantly, so you can't miss it. We can even render anything in there... like the actual commit IDs and messages in- and outgoing.

[mention-bot]

@joaomoreno, thanks for your PR! By analyzing the history of the files in this pull request, we identified @egamma, @bpasero and @aeschli to be potential reviewers.

[bgashler1]

@joaomoreno I think it's quite useful to show what you're proposing here for information sake (and the problem is probably less likely to occur with this), but I still think having prompt is a good safeguard to prevent first-timers from the unintended consequences of clicking this without reading this or understanding it. It also is making permanent changes to a remote repo's history, which I don't think should be taken lightly, even though it can be reverted with an additional commit. We don't want to hear "VS Code made me do it!" as an excuse for people that are chastised by their peers for pushing things they weren't supposed to.

I do agree though that if we do a prompt, it should have a "Never show this again" checkbox, or it could get tedious. @chrmarti your thoughts?

[chrmarti]

@bgashler1 We can't do that with the built-in confirmation dialog from what I see. We could replace it with our regular message box if we're fine with it not being 'blocking' as the confirmation dialog is.

[bgashler1]

@chrmarti that's too bad. I hesitate to use the notification alert. It feels like a dialog would make more sense, since we use that for irreversible actions like closing without saving, Git cleaning, etc... Just my opinion.

[joaomoreno]

@chrmarti @bgashler1

It seems to me that you are not up for discussion on this subject; we've been going back and forward on it for weeks. It started with the suggestion to introduce a confirmation dialog. Here we are today and you haven't budged. So I've just pushed 9601072.

[chrmarti]

Thanks @joaomoreno. Happy to discuss further. The important thing for me is that new users can no longer trigger the action without exactly knowing what it will do.