Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tunnel remote host #133584

Merged
merged 1 commit into from
Sep 22, 2021
Merged

Fix tunnel remote host #133584

merged 1 commit into from
Sep 22, 2021

Conversation

alexr00
Copy link
Member

@alexr00 alexr00 commented Sep 22, 2021

@alexr00
Copy link
Member Author

alexr00 commented Sep 22, 2021

The original fix for microsoft/vscode-remote-release#5613 caused the "Open in Browser" button in the ports view to stop working. This happened because the NodeRemoteTunnel no longer kept the original host as it's tunnelRemoteHost and instead changed to localhost if the host was localhost or all interfaces. Later, when commands try to find the tunnel, they end up looking for the original host, not localhost, and they don't find the tunnel.

@alexr00 alexr00 requested a review from alexdima September 22, 2021 09:31
alexdima
alexdima approved these changes Sep 22, 2021
View reviewed changes
Copy link
Member

@alexdima alexdima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@alexr00 alexr00 merged commit 7f6ab54 into release/1.60 Sep 22, 2021
@alexr00 alexr00 deleted the alexr00/tunnelRemoteHost branch September 22, 2021 11:45
@github-actions github-actions bot locked and limited conversation to collaborators Nov 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alexdima alexdima alexdima approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexr00 @alexdima