Add source map for every possible element in the Markdown preview #134799
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #133376
Summary
We have to clean up type definitions before the main work.
Update markdown-it and type definitions
markdown-it
and its DT so that they match now.dompurify
and its DT so that they match now.@types/highlight.js
becausehighlight.js
has its own type definitions since version 10.markdown-it
. Note that lots ofany
are removed to allow TypeScript to infer type.Refresh the source map mechanism in
markdownEngine.ts
addLineNumberRenderer()
withpluginSourceMap
as described in Add source map for every block-level element in the Markdown preview #133376.Note on
attrSet()
andattrGet()
markdown-it
'sToken
is designed in a bad smell with no access control.Given
Renderer.renderAttrs()
and the HTML Standard, an attribute set viaToken.attrSet()
should still work even in extreme cases.The use of
Token.attrGet()
is for a similar reason.