Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add optional directory syntax in file icon themes #137402

Closed
wants to merge 8 commits into from
Closed

Add optional directory syntax in file icon themes #137402

wants to merge 8 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Nov 18, 2021

This PR fixes #136656.

@ghost
Copy link
Author

ghost commented Nov 18, 2021

@aeschli's comment on the selector priority vs the cascade origin isn't implemented yet - #136656 (comment)

SNDST00M: M.U.N.I.N added 2 commits November 18, 2021 11:45
Regex check for file icon dirname (#137402)
77503a9
Escape dirname CSS class
716c55b 
This commit also limits the dirname selector to non-data resources.
@ghost
Copy link
Author

ghost commented Nov 26, 2021

Looks like the CI workflow has been broken by the merge commit 🤔

@ghost
Copy link
Author

ghost commented Nov 29, 2021 •
edited by ghost
Loading

Moved to keep things in context

@ghost
Copy link
Author

ghost commented Dec 6, 2021 •
edited by ghost
Loading

I am working on using a regex, but this code is clearly shared between vs/editor/common/services/getIconClasses and vs/workbench/services/themes/browser/fileIconThemeData.

Should I extract that to vs/base/common library and if so what should I call it?

@aeschli
Copy link
Contributor

aeschli commented Dec 7, 2021

@sndst00m Just keep it duplicated for now and I can see if it's something for common. We should maybe add something like vs/platform/theme/common/fileIcons

@ghost
Copy link
Author

ghost commented Dec 7, 2021

Right have at it :)

@ghost
Copy link
Author

ghost commented Dec 24, 2021 •
edited by ghost
Loading

Any thoughts on this before December endgame?

Nvm we have work to do on selector priority I think

@aeschli
Copy link
Contributor

aeschli commented Jan 2, 2022

The next endgame in end of January, so still time.

@ghost
Copy link
Author

ghost commented Jan 4, 2022 •
edited by ghost
Loading

Accidentally deleted the fork - restoring in #140079.

@ghost ghost closed this Jan 4, 2022
@ghost ghost mentioned this pull request Jan 4, 2022
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Feb 18, 2022
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@aeschli aeschli

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[icon-themes] Support for folder / directory names in file associations (Icon themes)
1 participant
@aeschli