Notify user when max folds exceeded, make max folds configurable. #140480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aeschli
approved these changes
Jan 11, 2022
|
Thanks a lot @PieterBranderhorst ! |
|
Thank you Martin! I'm glad my changes met your standards. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #72994
The changes can be tested by using any file with say 100 or more foldable regions and changing the new "Folding Maximum Regions" configuration value.
They should be tested separately with an extension folding range provider (e.g. typescript) and the indent based built-in provider (e.g. using plaintext.)