Bgashler1/issue/13529/no animation watermark #14331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Regression from commit b594287
|
@bgashler1, thanks for your PR! By analyzing the history of the files in this pull request, we identified @bpasero, @chrmarti and @kieferrm to be potential reviewers. |
|
I explored making the animation faster, but I still felt it was commanding attention and offering little value in return. So I removed it in this PR. This PR also addresses a display regression from b594287 where at small window sizes the logo would not recenter. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13529
Removes all animations/transitions from the watermark. Everything is instantaneous and snappy (including when you close editors, open a new window, and when you resize).
fyi @chrmarti