Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give git process clues in SCM input placeholder #144245

Closed

Conversation

gjsjohnmurray
Copy link
Contributor

This PR uses the SCM input placeholder to help a git novice know what to do.

When no changes exist:

image

When changes or untracked files exist but nothing has been staged yet:

image

After staging something the usual placeholder appears:

image

@lszomoru
Copy link
Member

lszomoru commented Mar 9, 2022

@gjsjohnmurray, thank you very much for your contribution. Rather than going down the path that is being proposed in this pull request, I would like to factor in this feedback in the work that is currently being tracked in #135992. I am hoping that this is something that we could probably take a look at next milestone.

//cc @misolori

@miguelsolorio
Copy link
Contributor

Appreciate the PR! Is there an original issue for this? Would be great to have a place to discuss before the PR.

@gjsjohnmurray
Copy link
Contributor Author

@misolori I confess I went straight to creating this PR. Pretty sure it arose from having responded to an issue in which a user was having a problem with the SCM view and seemed not to have grasped the sequence of steps. But I can't find that issue any more.

I created a branch to try out the idea on, then it seemed simpler to submit it as a PR than open a discussion issue first. No problem with me if you want to close it unmerged.

@gjsjohnmurray
Copy link
Contributor Author

Found the issue which prompted it - #142335

@joaomoreno joaomoreno added the git GIT issues label May 2, 2022
@lszomoru
Copy link
Member

@gjsjohnmurray, thanks again for your contribution. Today's Insiders release (2022-06-27) contains a Commit new action button which hopefully help users with committing their changes. Please give it a try and let me know what you think. I would like to further improve that experience in favour of using the placeholder text in the SCM Input. If you do not mind I will go ahead and close this PR.

@lszomoru lszomoru closed this Jun 27, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Aug 11, 2022
@gjsjohnmurray gjsjohnmurray deleted the add-git-staging-clue branch August 16, 2024 04:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
git GIT issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants