Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run multiple local extension hosts #144840

Merged
merged 11 commits into from
Mar 11, 2022
Merged

Run multiple local extension hosts #144840

merged 11 commits into from
Mar 11, 2022

Conversation

alexdima
Copy link
Member

@alexdima alexdima commented Mar 10, 2022 •
edited
Loading 

"extensions.experimental.affinity": {
   "vscode.git": 1,
   "vscode.typescript-language-features": 2
}

image

@alexdima alexdima self-assigned this Mar 10, 2022
@alexdima alexdima added this to the March 2022 milestone Mar 10, 2022
@alexdima
Towards having multiple extension hosts of the same ExtensionHostKind
d7b5c1a
@alexdima
Reduce assumptions that there is a single extension host of a certain…
23bb04d 
… kind
@alexdima
More removing of assumptions that there is a single extension host of…
7ba42f1 
… a certain kind
@alexdima
Reflect in IExtensionService methods that there might be multiple l…
d09791e 
…ocal process extension hosts available for inspection
@alexdima
Ask all local extension hosts to resolve canonical URIs
f6ad20b
@alexdima
Reduce usage of ExtensionHostKind to establish the running location
42dd8b0
@alexdima
Delay picking a running location until all desired extension host kin…
38daf83 
…ds have been computed
@alexdima
Compute affinity for extensions running in a local process extension …
3740be6 
…host
@alexdima
Launch multiple extension host processes
5b3c42c
@alexdima
Render affinity in the running extension editor
cf8969e
@alexdima alexdima merged commit 5f5e1ca into main Mar 11, 2022
@alexdima alexdima deleted the alex/multiple-local-extension-hosts branch March 11, 2022 22:12
@alexdima alexdima mentioned this pull request Mar 11, 2022
Closed
@kieferrm kieferrm mentioned this pull request Mar 14, 2022
Closed
87 tasks
@rebornix
Copy link
Member

I have been self hosting on this issue for a few days, it's working great ❤️

I also spent a bit time looking into how to build a command which can find all notebook extensions (or jupyter related) and update the affinity in a single configuration update so users won't need to figure that out themselves. However the configuration update is blocked as this is an unregistered configuration. @sandy081 mentioned maybe we can make this an experimental config but I also like the idea of having it as an unregistered one without making it public. @alexdima any suggestions here?

@rebornix
Copy link
Member

@alexdima ☝️ any thoughts?

@alexdima
Copy link
Member Author

@rebornix Pushed fc9e85e

@github-actions github-actions bot locked and limited conversation to collaborators Apr 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@alexdima alexdima

Labels
None yet
Projects
None yet
Milestone
March 2022
Development

Successfully merging this pull request may close these issues.
2 participants
@alexdima @rebornix