Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: unify artifacts processing on darwin #145226

Merged
merged 2 commits into from
Mar 17, 2022
Merged

Conversation

deepak1556
Copy link
Collaborator

@deepak1556 deepak1556 commented Mar 16, 2022

Follow-up to #145053 (comment)

This renames our x64 server archives file name from vscode-server-darwin.zip to vscode-server-darwin-x64.zip.

Please note this does not change the asset id related with this artifact and continues to remain server-darwin.

Downstream consumer, remote-ssh extension seems to rely on the asset id https://update.code.visualstudio.com/commit:<sha>/server-darwin rather than the file name, so this change should not break the extension. @roblourens @tanhakabir can you please confirm ?

@deepak1556 deepak1556 self-assigned this Mar 16, 2022
@deepak1556 deepak1556 added this to the March 2022 milestone Mar 16, 2022
@deepak1556
Copy link
Collaborator Author

Copy link
Member

@alexdima alexdima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thank you for jumping in to improve this!

@deepak1556 deepak1556 merged commit 791b350 into main Mar 17, 2022
@deepak1556 deepak1556 deleted the robo/cleaup_reosurce_upload branch March 17, 2022 07:53
@github-actions github-actions bot locked and limited conversation to collaborators May 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants