Delete built-in PowerShell snippets #146459
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These two snippets conflict with the PowerShell comment syntax (`<#`), and since snippet suggestions are enabled by default, it means it's not possible to type `<#` followed by an enter, which is very often desired. The enter unfortunately chooses to insert an entirely unhelpful `#endregion` snippet.
|
Thanks @andschwa. Makes sense. If the snippets are not helpful but often get in the way, let's remove them. |
|
Thanks @aeschli! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all,
PowerShell Extension maintainer here 👋
I finally tracked down the root of the bug PowerShell/vscode-powershell#3276, and realized it was not one of our extension's own contributed snippets, but instead built-in to Code.
These two snippets conflict with the PowerShell comment syntax (
<#), and since snippet suggestions are enabled by default, it means it's not possible to type<#followed by an enter, which is very often desired. The enter unfortunately chooses to insert an entirely unhelpful#endregionsnippet.The PowerShell extension ships its own snippets, and documents community snippets. We will actually also need to fix our own
#regionsnippet to fully fix this bug, but when I realized it was one of three suggested snippets after the insertion of a#in a PowerShell file, I investigated and found these two built-in snippets.Please accept this PR and remove these two snippets. They're not used, they're not helpful, and moreover, we have a far more extensive set of contributed snippets in the Code-recommended PowerShell extension.
/cc @TylerLeonhardt @SeeminglyScience @SydneyhSmith
This PR fixes PowerShell/vscode-powershell#3276