Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add comments to notebook editor API #149273

Merged
merged 1 commit into from
May 12, 2022
Merged

Add comments to notebook editor API #149273

merged 1 commit into from
May 12, 2022

Conversation

mjbvz
Copy link
Collaborator

@mjbvz mjbvz commented May 11, 2022

For #149271

  • Adds comments to all functions / properties
  • Updates the issue number in the proposal
  • Remove a todo comment about renaming a property. I think the current name is ok but we can revisit this

@mjbvz
Add comments to notebook editor API
ec43e06 
Also:

- Updates the issue number
- Remove a todo comment about renaming a property. I think the current name is ok but we can revisit this
@mjbvz mjbvz added this to the May 2022 milestone May 11, 2022
@mjbvz mjbvz requested review from rebornix and jrieken May 11, 2022 16:12
jrieken
jrieken approved these changes May 12, 2022
View reviewed changes
Copy link
Member

@jrieken jrieken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good but before finalizing we should revisit some names, like notebookEditor vs editor or document vs notebook

@mjbvz mjbvz merged commit 2e0cd6b into microsoft:main May 12, 2022
@mjbvz
Copy link
Collaborator Author

mjbvz commented May 12, 2022

Sounds good. Yes we can discuss the names at the new api sync

@github-actions github-actions bot locked and limited conversation to collaborators Jun 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jrieken jrieken jrieken approved these changes

@rebornix rebornix Awaiting requested review from rebornix

Assignees

@mjbvz mjbvz

Labels
None yet
Projects
None yet
Milestone
May 2022
Development

Successfully merging this pull request may close these issues.
2 participants
@mjbvz @jrieken