-
Notifications
You must be signed in to change notification settings - Fork 29.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finalize NotebookEditor api proposal #149767
Conversation
Fixes microsoft#149271 This finalizes most parts of the NotebookEditor api proposal. I haven't removed the proposal entirely as there are still a few parts being left behind: - The deprecated properties/functions - A few contribution points such as `notebook/cell/executePrimary`
|
Also |
That executePrimary menu is only needed for remotehub's "Continue Working On" prompt and it will go away when that moves to core. #149271 (comment) I think that menu shouldn't be finalized. Sorry for not calling that out. |
I've confirmed that Not sure if there are any other users. @roblourens Do you think we can safely finalize these two contributions? Or do they need to remain proposed |
@mjbvz I think both |
Follow up on microsoft#149271 Finalizing these two contributions based on microsoft#149767 (comment) We're leaving the `notebook/cell/executePrimary` point for now as we don't plan to finalize it
Follow up on #149271 Finalizing these two contributions based on #149767 (comment) We're leaving the `notebook/cell/executePrimary` point for now as we don't plan to finalize it
Fixes #149271
This finalizes most parts of the NotebookEditor api proposal. I haven't removed the proposal entirely as there are still a few parts being left behind:
notebook/cell/executePrimary