-
Notifications
You must be signed in to change notification settings - Fork 29.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a JavaScript Walkthrough #151665
Add a JavaScript Walkthrough #151665
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
commit #151663 # # # # # # @ @DanielRosenwasser
Cool to see this! Here's some real-time feedback as I step through the walkthrough. I won't nitpick on copy, icons, etc. for now: Step 1My first reaction was that the created HTML file was way more "complete" than I would have expected. My assumption is that there wouldn't be any JavaScript written yet, and that I'd do it myself at a later step. Step 2
Step 3Not sure at this point why I need node since I was just in the browser. Is there an outcome we can use instead? Makes sense to hide this if Node is already installed. Seems reasonable to link to the page, in any case. Step 4It took me a second to realize this was sort of a different task altogether. I originally thought I'd be creating a new Reading the step's description again, it seems like that's made somewhat clear at the end. But it still could be easily read as creating a new file to link to in the HTML file via a script tag. And many people won't read the description 😉 Overall thoughtsNow that I've been through it, a couple of high-level thoughts come to mind:
Excited for this! |
@daviddossett are you talking about the old "Debugger for Chrome" extension? That is marked as deprecated in the marketplace now, where do you see it? |
Or maybe you just saw the "Web app (Chrome)" entry in the debugger list, checking for a chrome install before including that could be a js-debug feature request |
Yeah it was this. I ended up getting an error since I wasn't thinking and just hit enter. I'll file an issue. |
@DanielRosenwasser great work, I think this will be a great addition to the getting started page!
I plan to provide more feedback next week, so we do not drown you in feedback on day 1 :) Thanks a lot for working on this! fyi @connor4312 @weinand for debugging ideas |
@daviddossett thank you for the feedback!
This is possibly something we can condition with an experiment - but I do think we should have some JS that does something basic like setting text on an HTML element (e.g.
Yeah, I 100% agree - debugging is not what I care about at this point, and all I'm trying to do is make it easy to view the web page. 😅 I went back and forth on this because I wasn't sure how much we should teach and when. We're going to tell people "Hit F5 to run!", but then at some point they'll learn that it's actually debugging - and maybe that's okay? In that case, should I not have the button focus on the debug output pane?
Weird, I'll double check this.
Huh, I think the intent for this walkthrough was to not surface this as an option in the browser. What kind of environment were you in?
@chrisdias suggested this too. I'm happy to rethink this tutorial as a way to start building web pages in Visual Studio Code. For example:
But it might take some time to get that going. |
Weird, those seem to say that an import to
👍🏻 |
This PR provides a built-in JavaScript walkthrough in Visual Studio Code. I think on some level we believe there's a group of beginners who are likely to stop using Visual Studio Code because they download it and don't know what to do next. Giving a walkthrough provides a clearer path on what those next steps are. So while we originally wanted to do a TypeScript walkthrough, it made more sense to just provide a JavaScript walkthrough, since TypeScript typically involves considering a build step, bundling, and assumes some level of comfort in JavaScript itself.
While we can provide a TypeScript walkthrough in the future, there are ideas in #144062 that will likely simplify the walkthrough as well. In other words, I think that making the built-in experience for VS Code better will make the walkthroughs better too.
Huge thanks to @luabud for laying the foundation on the Python side.
Fixes microsoft/TypeScript#48489
Ticks a box off on #144062
Here's the current TODOs, with some specific callouts that I'd appreciate some input on.
.mjs
file or.js
file? Leaning towards.js
.<script>
or F5 in the walkthrough steps. (@JacksonKearl)prompt()
/alert()
?