Create new shell integration test suite that uses recordings instead of depending on processes/environment #152736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI @meganrogge |
lramos15
previously approved these changes
Jun 21, 2022
lramos15
previously approved these changes
Jun 21, 2022
lramos15
approved these changes
Jun 21, 2022
|
Success! Rerunning CI and also a product build to make sure. |
|
looks great 👍🏼 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #152658
These tests don't test the shell integration scripts but should eliminate flakiness and allow testing of recordings expected to come through from shells, exercising all the code on the vscode side. A functional change is also made here to allow the display of command decorations even when shell integration is disabled, this is required not just for the tests but for the manual install of shell integration scripts (#151933) and for alternative shell integration sequence support (#146587).