-
Notifications
You must be signed in to change notification settings - Fork 29.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flexible-width Find Menu in Notebook #154550
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreamah
changed the title
Expandable Find Menu in Notebook
Flexible-width Find Menu in Notebook
Jul 11, 2022
andreamah
commented
Jul 13, 2022
src/vs/workbench/contrib/notebook/browser/contrib/find/notebookFindReplaceWidget.css
Show resolved
Hide resolved
andreamah
commented
Jul 13, 2022
src/vs/workbench/contrib/notebook/browser/contrib/find/notebookFindReplaceWidget.ts
Show resolved
Hide resolved
roblourens
reviewed
Jul 13, 2022
src/vs/workbench/contrib/notebook/browser/contrib/find/notebookFindReplaceWidget.ts
Outdated
Show resolved
Hide resolved
src/vs/workbench/contrib/notebook/browser/contrib/find/notebookFindReplaceWidget.ts
Outdated
Show resolved
Hide resolved
src/vs/workbench/contrib/notebook/browser/contrib/find/notebookFindReplaceWidget.ts
Show resolved
Hide resolved
roblourens
reviewed
Jul 14, 2022
src/vs/workbench/contrib/notebook/browser/contrib/find/notebookFindReplaceWidget.ts
Outdated
Show resolved
Hide resolved
roblourens
approved these changes
Jul 15, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #141516
This allows the file box to adjust width. Double-clicking will reset the width (to the minimum) or expand to the max width if it is already at the minimum width).