Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow more args in run task #154854

Merged
merged 17 commits into from
Jul 13, 2022
Merged

allow more args in run task #154854

merged 17 commits into from
Jul 13, 2022

Conversation

meganrogge
Copy link
Contributor

@meganrogge meganrogge commented Jul 11, 2022

This PR fixes #154201
fixes #153145

to do:
get intellisense to work

@meganrogge meganrogge marked this pull request as draft July 11, 2022 21:14
@vscodenpa vscodenpa added this to the July 2022 milestone Jul 11, 2022
@aeschli aeschli self-requested a review July 11, 2022 21:56
aeschli
aeschli previously approved these changes Jul 11, 2022
@meganrogge meganrogge marked this pull request as ready for review July 11, 2022 23:03
@meganrogge meganrogge requested a review from Tyriar July 11, 2022 23:03
@meganrogge meganrogge marked this pull request as draft July 11, 2022 23:12
@meganrogge
Copy link
Contributor Author

fyi there's an issue with using the instantiation service @Tyriar so reverted that and think it's why it wasn't used in the first place.

@Tyriar
Copy link
Member

Tyriar commented Jul 13, 2022

@meganrogge was the issue just that the @ decorators are missing here?

constructor(
private _taskService: ITaskService,
private _configurationService: IConfigurationService,
private _quickInputService: IQuickInputService,
private _notificationService: INotificationService,
private _themeService: IThemeService,
private _dialogService: IDialogService) {
super();
this._sorter = this._taskService.createSorter();
}

@meganrogge meganrogge marked this pull request as ready for review July 13, 2022 17:15
@meganrogge meganrogge enabled auto-merge (squash) July 13, 2022 17:16
@meganrogge meganrogge merged commit 6ce1ad6 into main Jul 13, 2022
@meganrogge meganrogge deleted the merogge/task-run-config branch July 13, 2022 17:25
Yoyokrazy pushed a commit to Yoyokrazy/vscode that referenced this pull request Jul 13, 2022
andreamah pushed a commit that referenced this pull request Jul 14, 2022
jrieken pushed a commit that referenced this pull request Jul 18, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Aug 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow an object for arguments in runTask Add command for filtering task quick open entries
4 participants