Double check IW is the notebook changing when handling scroll events #155095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rebornix
reviewed
Jul 13, 2022
src/vs/workbench/contrib/interactive/browser/interactiveEditor.ts
Outdated
Show resolved
Hide resolved
roblourens
reviewed
Jul 13, 2022
| const cell = this.#notebookWidget.value?.getCellByHandle(e.cellHandle); | ||
| if (cell && e.changed?.state) { | ||
| this.#scrollIfNecessary(cell); | ||
| if (isEqual(e.notebook, this.#notebookWidget.value?.viewModel?.notebookDocument.uri)) { |
There was a problem hiding this comment.
The event also has a helper method affectsNotebook that does the same as this
roblourens
approved these changes
Jul 13, 2022
Yoyokrazy
pushed a commit
to Yoyokrazy/vscode
that referenced
this pull request
Jul 13, 2022
…icrosoft#155095) * Fix 155092 * Review feedback
andreamah
pushed a commit
that referenced
this pull request
Jul 14, 2022
…155095) * Fix 155092 * Review feedback
jrieken
pushed a commit
that referenced
this pull request
Jul 18, 2022
…155095) * Fix 155092 * Review feedback
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #155092