support watch task reconnection #155120
Merged
support watch task reconnection #155120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meganrogge
commented
Jul 13, 2022
Tyriar
requested changes
Jul 14, 2022
| @@ -167,6 +167,8 @@ export interface IPtyHostAttachTarget { | |||
| icon: TerminalIcon | undefined; | |||
| fixedDimensions: IFixedTerminalDimensions | undefined; | |||
| environmentVariableCollections: ISerializableEnvironmentVariableCollections | undefined; | |||
| reconnectionOwner?: string; | |||
| task?: { label: string; id: string; lastTask?: string; group?: string }; | |||
There was a problem hiding this comment.
Can this be a reconnection owner id or something and this data gets persisted by contrib/tasks? We don't want to mention tasks anywhere in terminal ideally
There was a problem hiding this comment.
This?
reconnectionOwner: {
ownerName: string;
ownerId: number;
}There was a problem hiding this comment.
If that's not easily doable, a temporary fix is to give this a generic name with type unknown and validate the type in tasks. I'd be fine for that to live in terminal as it basically moves the tech debt out of terminal and into tasks.
| @@ -347,7 +364,7 @@ export abstract class AbstractTaskService extends Disposable implements ITaskSer | |||
| return this.inTerminal(); | |||
| } | |||
|
|
|||
| private _registerCommands(): void { | |||
| private async _registerCommands(): Promise<void> { | |||
Tyriar
previously approved these changes
Jul 14, 2022
Tyriar
approved these changes
Jul 14, 2022
andreamah
pushed a commit
that referenced
this pull request
Jul 14, 2022
This was referenced Jul 14, 2022
jrieken
pushed a commit
that referenced
this pull request
Jul 18, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #117408
To do/ might defer: