Implements current line highlighting with modes 'line', 'gutter' and 'all' #15612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rebornix, thanks for your PR! By analyzing the history of the files in this pull request, we identified @alexandrudima, @bpasero and @jrieken to be potential reviewers. |
|
Awesome! 👍 |
alexdima
added a commit
that referenced
this pull request
Nov 18, 2016
…ht"" This reverts commit ce97d43.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement feature request #14273. Previously we only highlight current line or not but here we allow users to decide where they want to show the hint, gutter, line, both or none.
"editor.renderLineHighlight": "gutter"will be likeIt helps mitigate #3803 , cc @bgashler1
Right now I'm just using the same background color in gutter as highlighted current line but it can be different. The good part of using the same color for both line and gutter is that current line highlight color is a TM setting, we don't need to introduce a new concept.