Support for pasting images into markdown notebook cells #156847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 16 commits
July 22, 2022 13:28
… inside MarkupCell
Yoyokrazy
requested review from
mjbvz and
rebornix
and removed request for
mjbvz
mjbvz
requested changes
Aug 1, 2022
mjbvz
reviewed
Aug 2, 2022
mjbvz
requested changes
Aug 2, 2022
src/vs/workbench/contrib/notebook/browser/view/renderers/webviewPreloads.ts
Outdated
Show resolved
Hide resolved
src/vs/workbench/contrib/notebook/browser/view/renderers/backLayerWebView.ts
Outdated
Show resolved
Hide resolved
|
Current snippet functionality is attached in this image. Ended up using the |
mjbvz
requested changes
Aug 3, 2022
roblourens
reviewed
Aug 3, 2022
added 5 commits
August 4, 2022 10:15
mjbvz
previously approved these changes
Aug 4, 2022
rebornix
approved these changes
Aug 8, 2022
joyceerhl
pushed a commit
that referenced
this pull request
Aug 10, 2022
* dataflow support for updated metadata * update cellAttachmentRenderer.ts to reflect metadata being a getter() inside MarkupCell * document paste additions * update condition to re-render cells, now includes metadata changes * paste API working, debugging command added * paste working with metadata. needs numbering, and cleaning upon delete * paste screenshot works fully * remove debugging command. Cleaning. * notebook cells now re-render upon metadata changes * changed name validity checking, remove unneeded function * use _document for cell data, use snippet choice, dto fix * return subscription, for loop, uri fix, alter metadata in-place, better snippet * metadata fix, object.equals, fix cellAttRenderer metadata call * added comment with source of encodeBase64 * gate mkdn image paste behind experimental setting
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #151408 #119961
Adds support for pasting images into markdown cells. Works either with screenshots or copying files from file explorer.
Currently limited to only
image/pngmime type.