Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enabled core cell delete for IW and undo operations #158421

Merged
merged 4 commits into from
Sep 16, 2022

Conversation

amunger
Copy link
Contributor

@amunger amunger commented Aug 17, 2022

microsoft/vscode-jupyter#7756

  • Check if an operation should be placed on the undo stack, rather than checking if undo is available at all
    • The interactive window is a partially read-only notebook, and delete cell is an exception since it can be performed by the user. We want to enable undo for that operation
  • deleting a cell while having focus elsewhere requires first focusing on the history, but doesn't always work depending on which component was actually given focus (out of scope issue)
  • Also stopped some maintenance code from being placed on the undo stack (reset)

@amunger amunger requested a review from rebornix August 17, 2022 23:23
@amunger amunger force-pushed the undoIWCellDelete branch 2 times, most recently from a295aca to 43702c9 Compare September 8, 2022 22:56
@@ -402,7 +402,7 @@ export class NotebookTextModel extends Disposable implements INotebookTextModel
true,
undefined, () => undefined,
undefined,
true
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was strange and feels like it should be false. It's only called on creation of notebooks as far as I could tell: Create a notebook, ctrl+z - a no-op undo is performed

@amunger amunger marked this pull request as ready for review September 8, 2022 23:05
@amunger amunger requested a review from alexdima September 8, 2022 23:05
@vscodenpa vscodenpa added this to the September 2022 milestone Sep 8, 2022
@rebornix rebornix requested review from jrieken and removed request for alexdima September 8, 2022 23:18
@rebornix
Copy link
Member

rebornix commented Sep 8, 2022

It would be great if @jrieken can help take a look at the change in how applyEdits is changed.

@amunger
Copy link
Contributor Author

amunger commented Sep 12, 2022

@jrieken - any feedback on the changes here?

@amunger amunger merged commit 236e476 into microsoft:main Sep 16, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Oct 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants