Remove notebook content provider save and backup functionality #160581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For microsoft#147248 When stepping through the liveshare code, we figured out they do not appear to be using `save`, `saveAs`, or `backup` (they return empty results for these) This PR removes this part of the proposal so we can track just the parts of the api that they are using
mjbvz
commented
Sep 9, 2022
| @@ -22,8 +22,6 @@ export interface INotebookContentProvider { | |||
| options: TransientOptions; | |||
|
|
|||
| open(uri: URI, backupId: string | VSBuffer | undefined, untitledDocumentData: VSBuffer | undefined, token: CancellationToken): Promise<{ data: NotebookData; transientOptions: TransientOptions }>; | |||
| save(uri: URI, token: CancellationToken): Promise<boolean>; | |||
| saveAs(uri: URI, target: URI, token: CancellationToken): Promise<boolean>; | |||
| backup(uri: URI, token: CancellationToken): Promise<string | VSBuffer>; | |||
There was a problem hiding this comment.
I left backup in place here as the interactive window still seems to be using it
mjbvz
commented
Sep 9, 2022
| @@ -377,7 +377,7 @@ export class ComplexNotebookEditorModel extends EditorModel implements INotebook | |||
| if (!this.isResolved()) { | |||
| return; | |||
| } | |||
| const success = await this._contentProvider.save(this.notebook.uri, CancellationToken.None); | |||
| const success = false; | |||
There was a problem hiding this comment.
Not familiar enough with this code to do a better fix
The interactive window always returns false for these methods
rebornix
approved these changes
Sep 12, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #147248
When stepping through the liveshare code, we figured out they do not appear to be using
save,saveAs, orbackup(they return empty results for these)This PR removes this part of the proposal so we can track just the parts of the api that they are using